[webkit-reviews] review denied: [Bug 34804] Some WTF headers fail to compile under VS2008 and newer : [Attachment 188575] Patch proposed for removing inline statement in order to compile under VS2008 (updated)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Victor Bonnedun
<victor.bonnedun at gmail.com>'s request for review:
Bug 34804: Some WTF headers fail to compile under VS2008 and newer
https://bugs.webkit.org/show_bug.cgi?id=34804

Attachment 188575: Patch proposed for removing inline statement in order to
compile under VS2008 (updated)
https://bugs.webkit.org/attachment.cgi?id=188575&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188575&action=review


Patch is incorrect, at least for non-Microsoft compilers, has no change log,
and also does not apply successfully.

> JavaScriptCore/heap/PassWeak.h:162
> -template<typename T> PassWeak<T> inline adoptWeak(WeakImpl* impl)
> +template<typename T> PassWeak<T> adoptWeak(WeakImpl* impl)

This is an unacceptable change for other compilers. The inline keyword tells
the compiler to inline this function. Not sure why Microsoft’s compiler is
having a problem with this, but please don’t punish all others for this
mistake.