[webkit-reviews] review granted: [Bug 109902] [JSC] MAYBE_MISSING_PARAMETER(..., DefaultIsNullString) macro is redundant : [Attachment 188494] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 109902: [JSC] MAYBE_MISSING_PARAMETER(..., DefaultIsNullString) macro is
redundant
https://bugs.webkit.org/show_bug.cgi?id=109902

Attachment 188494: Patch
https://bugs.webkit.org/attachment.cgi?id=188494&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188494&action=review


> Source/WebCore/bindings/js/JSDOMBinding.h:62
> +#define MissingIsNullString(exec, index) (((index) >=
(exec)->argumentCount()) ? (JSValue()) : ((exec)->argument(index)))

Same comment.  This should probably be an inline function.  If it can't be an
inline function, we should keep the ALL_CAPS name.