[webkit-reviews] review granted: [Bug 109899] [V8] MAYBE_MISSING_PARAMETER() macro is overkilling : [Attachment 188488] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 15 09:07:22 PST 2013
Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 109899: [V8] MAYBE_MISSING_PARAMETER() macro is overkilling
https://bugs.webkit.org/show_bug.cgi?id=109899
Attachment 188488: Patch
https://bugs.webkit.org/attachment.cgi?id=188488&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188488&action=review
> Source/WebCore/bindings/v8/V8BindingMacros.h:55
> +#define MissingIsNullString(args, index) \
Can we make this an inline function instead of a pre-processor macro? (If not,
we should keep the ALL_CAPS name to let callers know that it's a macro.)
More information about the webkit-reviews
mailing list