[webkit-reviews] review granted: [Bug 109684] [EFL][WK2] Have WebView subclass PageClient : [Attachment 188344] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 15 08:29:08 PST 2013


Anders Carlsson <andersca at apple.com> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 109684: [EFL][WK2] Have WebView subclass PageClient
https://bugs.webkit.org/show_bug.cgi?id=109684

Attachment 188344: Patch
https://bugs.webkit.org/attachment.cgi?id=188344&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188344&action=review


> Source/WebKit2/UIProcess/efl/WebView.cpp:161
> +    OwnPtr<DrawingAreaProxy> drawingArea =
DrawingAreaProxyImpl::create(page());
> +    return drawingArea.release();

Can just return DrawingAreaProxyImpl::create(page()) directly here.


More information about the webkit-reviews mailing list