[webkit-reviews] review denied: [Bug 109439] Update calendar picker UI : [Attachment 188474] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 109439: Update calendar picker UI
https://bugs.webkit.org/show_bug.cgi?id=109439

Attachment 188474: Patch
https://bugs.webkit.org/attachment.cgi?id=188474&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188474&action=review


> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests. Covered by calendar picker appearance tests.

Please write what are user-visible changes briefly

> Source/WebCore/Resources/pagepopups/calendarPicker.css:-2
> -/*
> - * Copyright (C) 2012 Google Inc. All rights reserved.

Don't remove the copyright header

> Source/WebCore/Resources/pagepopups/calendarPicker.js:-3
> -/*
> - * Copyright (C) 2012 Google Inc. All rights reserved.

Ditto.

> Source/WebCore/platform/text/mac/LocaleMac.mm:212
> +    // Gets a format for "MMMM" because Windows API always provides formats
for
> +    // "MMMM" in some locales.

bogus comment

> LayoutTests/platform/chromium/TestExpectations:4123
> +webkit.org/b/109439
platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.h
tml [ Failure Pass ]
> +webkit.org/b/109439
platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.h
tml [ Failure Pass ]
> +webkit.org/b/109439
platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.h
tml [ Failure Pass ]
> +webkit.org/b/109439
platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.h
tml [ Failure Pass ]
> +webkit.org/b/109439
platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.h
tml [ Failure Pass ]

What do this duplicated lines mean?

>
LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-with-s
tep-expected.txt:9
> -PASS availableDatesInCurrentMonth().join(",") is ["2011-05-08",
"2011-05-17", "2011-05-26"].join(",")
> +FAIL availableDatesInCurrentMonth().join(",") should be
2011-05-08,2011-05-17,2011-05-26. Was .
>  Step when min is set.
> -PASS availableDatesInCurrentMonth().join(",") is ["2011-05-01",
"2011-05-10", "2011-05-19", "2011-05-28"].join(",")
> +FAIL availableDatesInCurrentMonth().join(",") should be
2011-05-01,2011-05-10,2011-05-19,2011-05-28. Was .

FAIL

>
LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-mouse-ope
rations-expected.txt:15
> -PASS selectedMonth() is "2000-02"
> +FAIL highlightedValue() should be 2000-02. Was 2000-01.

FAIL

>
LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-with-step
-expected.txt:11
> -PASS availableDatesInCurrentMonth()[0] is "2011-04-01"
> -PASS availableDatesInCurrentMonth()[29] is "2011-04-30"
> +FAIL availableDatesInCurrentMonth()[0] should be 2011-04-01 (of type
string). Was undefined (of type undefined).
> +FAIL availableDatesInCurrentMonth()[29] should be 2011-04-30 (of type
string). Was undefined (of type undefined).
>  Step when min is set.
> -PASS availableDatesInCurrentMonth()[0] is "2012-02-01"
> -PASS availableDatesInCurrentMonth()[28] is "2012-02-29"
> +FAIL availableDatesInCurrentMonth()[0] should be 2012-02-01 (of type
string). Was undefined (of type undefined).
> +FAIL availableDatesInCurrentMonth()[28] should be 2012-02-29 (of type
string). Was undefined (of type undefined).

FAIL