[webkit-reviews] review denied: [Bug 109874] Update FeatureObserver on top level navigation : [Attachment 188448] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kassy Coan <kassycoan at gmail.com>'s
request for review:
Bug 109874: Update FeatureObserver on top level navigation
https://bugs.webkit.org/show_bug.cgi?id=109874

Attachment 188448: Patch
https://bugs.webkit.org/attachment.cgi?id=188448&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188448&action=review


> Source/WebCore/loader/FrameLoader.cpp:3272
> +	  
m_frame->page()->setFeatureObserver(adoptPtr(reinterpret_cast<FeatureObserver*>
(0)));

You can write:

m_frame->page()->setFeatureObserver(nullptr)

which is a bit cleaner.

> Source/WebCore/page/FeatureObserver.cpp:45
> +   
HistogramSupport::histogramEnumeration("WebCore.FeatureObserver.TrackingStats",
PageVisits, NumberOfStatistics);

I'd prefer to use the same histogram for the baseline stats as for the other
stats.	That makes sure they stay in sync.

> Source/WebCore/page/FeatureObserver.cpp:66
> +    if (!page->featureObserver())
> +	   page->setFeatureObserver(adoptPtr(new FeatureObserver()));

Rather than calling "new" and "delete" all the time, we can just trigger
measurement on navigation and reset the m_featureBits.