[webkit-reviews] review granted: [Bug 109753] CORS preflight broken with NetworkProcess : [Attachment 188393] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 14 16:14:58 PST 2013


Brady Eidson <beidson at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 109753: CORS preflight broken with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=109753

Attachment 188393: proposed fix
https://bugs.webkit.org/attachment.cgi?id=188393&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188393&action=review


>> Source/WebCore/loader/DocumentThreadableLoader.cpp:356
>> +	if (m_actualRequest) {
>> +	    InspectorInstrumentation::didFailLoading(m_document->frame(),
m_document->frame()->loader()->documentLoader(), identifier, error);
>> +	}
> 
> One line control clauses should not use braces.  [whitespace/braces] [4]

Listen to style-bot here


More information about the webkit-reviews mailing list