[webkit-reviews] review granted: [Bug 104750] webdatabase: Split the SQLTransaction between its front-end and back-end. : [Attachment 188400] The patch (with build fixes, ChangeLog, and more comprehensive comments).

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Mark Lam <mark.lam at apple.com>'s request
for review:
Bug 104750: webdatabase: Split the SQLTransaction between its front-end and
back-end.
https://bugs.webkit.org/show_bug.cgi?id=104750

Attachment 188400: The patch (with build fixes, ChangeLog, and more
comprehensive comments).
https://bugs.webkit.org/attachment.cgi?id=188400&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188400&action=review


> Source/WebCore/Modules/webdatabase/ChangeVersionData.h:45
> +    const String& m_oldVersion;
> +    const String& m_newVersion;

These should be String.

> Source/WebCore/Modules/webdatabase/DatabaseBackendContext.cpp:37
> +    return static_cast<DatabaseContext*>(this);

This could use a comment.

> Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:95
> +#define ARRAY_SIZE(x) (sizeof(x) / sizeof(x[0]))

We already have WTF_ARRAY_LENGTH, which is a safer version of this.