[webkit-reviews] review granted: [Bug 14762] percentage top value of position:relative element not calculated using parent's min-height unless height set : [Attachment 187140] Patch

Thu Feb 14 12:59:42 PST 2013

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 14762: percentage top value of position:relative element not calculated
using parent's min-height unless height set
https://bugs.webkit.org/show_bug.cgi?id=14762

Attachment 187140: Patch
https://bugs.webkit.org/attachment.cgi?id=187140&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187140&action=review

> LayoutTests/ChangeLog:13
> +	   *
fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-expec
ted.html: Added.
> +	   *
fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor.html:
Added.
> +	   *
fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fi
xed-ancestor-expected.html: Added.
> +	   *
fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fi
xed-ancestor.html: Added.

Could it be possible to have vertical-writing mode version of these tests?

> LayoutTests/fast/block/percent-top-parent-respects-min-height.html:39
> +	   <script>
> +	       checkLayout('.box')
> +	   </script>

You can put that on an onload listener:

<body onload="checkLayout('.box')">

>
LayoutTests/fast/replaced/computed-image-width-with-percent-height-and-fixed-an
cestor-expected.html:19
> +

Stray empty line (present on all the following files but not repeated).