[webkit-reviews] review granted: [Bug 103259] Numeric identifiers of events are not guaranteed to be unique : [Attachment 176889] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Cosmin Truta
<ctruta at gmail.com>'s request for review:
Bug 103259: Numeric identifiers of events are not guaranteed to be unique
https://bugs.webkit.org/show_bug.cgi?id=103259

Attachment 176889: Patch
https://bugs.webkit.org/attachment.cgi?id=176889&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176889&action=review


> Source/WebCore/Modules/geolocation/Geolocation.cpp:318
> +    } while (UNLIKELY(!m_watchers.add(watchID, notifier)));

Please don't put this UNLIKELY here. It's not hot code, and there is no need to
add visual noise to it.