[webkit-reviews] review granted: [Bug 109060] Use GL typedefs in WebGLRenderingContext.idl : [Attachment 188313] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 109060: Use GL typedefs in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=109060

Attachment 188313: Patch
https://bugs.webkit.org/attachment.cgi?id=188313&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188313&action=review


This looks great. Thank you for pushing this through. It brings WebKit's IDL
much closer to the real Web IDL for this spec. r=me

> Source/WebCore/html/canvas/WebGLRenderingContext.idl:540
>      [StrictTypeChecking] int 	 getAttribLocation(in WebGLProgram
program, in DOMString name);

Is there some issue with changing this to return GLint? Could you file a bug to
track this discrepancy?