[webkit-reviews] review granted: [Bug 109784] String(Vector) behaves differently from String(vector.data(), vector.size()) for vectors with inline capacity in the size=0 case : [Attachment 188378] Back to the original fix, now with more context

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 109784: String(Vector) behaves differently from String(vector.data(),
vector.size()) for vectors with inline capacity in the size=0 case
https://bugs.webkit.org/show_bug.cgi?id=109784

Attachment 188378: Back to the original fix, now with more context
https://bugs.webkit.org/attachment.cgi?id=188378&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188378&action=review


> Source/WTF/wtf/text/WTFString.h:118
> +    // NOTE: This is different from String(vector.data(), vector.size())
> +    // which will sometimes return a null string when vector.data() is null
> +    // which can only occur for vectors without inline capacity.
> +    // See: https://bugs.webkit.org/show_bug.cgi?id=109792

I personally would not include this note, but I’m OK leaving it in.