[webkit-reviews] review granted: [Bug 95720] Simplify hitTestResultAtPoint and nodesFromRect APIs : [Attachment 188066] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 95720: Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720

Attachment 188066: Patch
https://bugs.webkit.org/attachment.cgi?id=188066&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188066&action=review


r=me, but fix the bad change.

> Source/WebKit/chromium/src/WebViewImpl.cpp:1094
> +    HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly |
HitTestRequest::Active | ((zoomType == FindInPage) ?
HitTestRequest::IgnoreClipping : 0);

Nit: I would put the zoomType checks to the next line for readibility.

> Source/WebKit/mac/WebView/WebHTMLView.mm:6205
> +    HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly |
HitTestRequest::Active | (allow ? HitTestRequest::AllowShadowContent : 0);

Same nit.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1766
> +	   HitTestResult result =
mainframe->eventHandler()->hitTestResultAtPoint(mainframe->view()->windowToCont
ents(point), HitTestRequest::ReadOnly | HitTestRequest::Active |
HitTestRequest::AllowShadowContent);

This is wrong, it should be:  HitTestRequest::ReadOnly | HitTestRequest::Active
| HitTestRequest::IgnoreClipping