[webkit-reviews] review denied: [Bug 107338] [chromium] support the lucid version of freetype on precise in DRT : [Attachment 188238] s/TODO(dpranke)/FIXME

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 14 09:41:18 PST 2013


Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 107338: [chromium] support the lucid version of freetype on precise in DRT
https://bugs.webkit.org/show_bug.cgi?id=107338

Attachment 188238: s/TODO(dpranke)/FIXME
https://bugs.webkit.org/attachment.cgi?id=188238&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188238&action=review


> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:47
> +	       ['OS=="unix"', {

How does this work?  I thought OS was
linux/win/mac/freebsd/openbsd/solaris/ios/android.

> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:48
> +		   'use_custom_freetype%': 0,  # FIXME: This should be on by
default.

Bug link?


More information about the webkit-reviews mailing list