[webkit-reviews] review denied: [Bug 109832] Web Inspector: Move profiler tools into separate panels : [Attachment 188363] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexei Filippov
<alph at chromium.org>'s request for review:
Bug 109832: Web Inspector: Move profiler tools into separate panels
https://bugs.webkit.org/show_bug.cgi?id=109832

Attachment 188363: Patch
https://bugs.webkit.org/attachment.cgi?id=188363&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188363&action=review


> Source/WebCore/inspector/front-end/CPUProfileView.js:578
> +    WebInspector.ProfileType.call(this, WebInspector.CPUProfileType.TypeId,
WebInspector.UIString("Collect JavaScript CPU Profile"), panel);

So what is profiles panel now? Making a dependency from profile type descriptor
to the UI component does not sound right to me.

> Source/WebCore/inspector/front-end/inspector.js:295
> +	       // TODO(alph): route to the appropriate profiler

// FIXME: (with no name)