[webkit-reviews] review denied: [Bug 109790] Web Inspector: [Resources] Improve linkifier plugins. : [Attachment 188279] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 109790: Web Inspector: [Resources] Improve linkifier plugins.
https://bugs.webkit.org/show_bug.cgi?id=109790

Attachment 188279: Patch
https://bugs.webkit.org/attachment.cgi?id=188279&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188279&action=review


> Source/WebCore/ChangeLog:12
> +	   This patch turns linkier plugin to interface responsible for
checking

linkifier

> Source/WebCore/inspector/front-end/ProfilesPanel.js:788
> +    showProfile: function(typeId, title, uid)

title is not used.

> Source/WebCore/inspector/front-end/ResourceUtils.js:56
> +WebInspector.ProfileURLRegExp = /webkit-profile:\/\/(.+)\/(.+)#([0-9]+)/;

ResourceUtils should know nothing about the profiler.