[webkit-reviews] review granted: [Bug 109771] Message generation should handle nested templates : [Attachment 188227] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 109771: Message generation should handle nested templates
https://bugs.webkit.org/show_bug.cgi?id=109771

Attachment 188227: Patch
https://bugs.webkit.org/attachment.cgi?id=188227&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188227&action=review


> Source/WebKit2/ChangeLog:13
> +	   (template_parameters):
> +	   (class_template_headers):

Maybe explain that they're mutually recursive?

> Source/WebKit2/Scripts/webkit2/messages.py:376
> +	   return ([], [template_string])

Why don't we use dictionary for the return value instead so that we don't have
to remember which one is which?
Also, you don't need parenthesis here.

> Source/WebKit2/Scripts/webkit2/messages.py:439
> +    headers = []

How about using set() for headers so that we don't include the same header
multiple times?

> Source/WebKit2/Scripts/webkit2/messages.py:452
> +	   split = type.split('::')
> +	   if len(split) < 2:
> +	       continue

Should we support fully qualified names like ::WTF::HashMap?