[webkit-reviews] review granted: [Bug 96798] [V8] Binding: Implement EnforceRange IDL Attribute for long long conversions : [Attachment 188229] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 96798: [V8] Binding: Implement EnforceRange IDL Attribute for long long
conversions
https://bugs.webkit.org/show_bug.cgi?id=96798

Attachment 188229: Patch
https://bugs.webkit.org/attachment.cgi?id=188229&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188229&action=review


LGTM.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1252
> +	       my $value = JSValueToNative($attribute->signature, "value",
"info.GetIsolate()", 1);

1 is unclear. Let's pass a string "canThrowException".