[webkit-reviews] review granted: [Bug 108892] Passing alpha to DeferredImageDecoder once decoding completes : [Attachment 188163] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Min Qin
<qinmin at chromium.org>'s request for review:
Bug 108892: Passing alpha to DeferredImageDecoder once decoding completes
https://bugs.webkit.org/show_bug.cgi?id=108892

Attachment 188163: Patch
https://bugs.webkit.org/attachment.cgi?id=188163&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188163&action=review


OK.  r=me

> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.cpp:227
> +    MutexLocker lock(m_alphaMutex);
> +    return m_hasAlpha;

I know I'll regret asking this, since threading has a long history of making me
look like an idiot, but why do you need to lock the mutex for a read?  It's a
bool, so all reads should be atomic anyway, no?