[webkit-reviews] review granted: [Bug 109765] Reschedule shared CFRunLoopTimer instead of reconstructing it : [Attachment 188213] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 109765: Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765

Attachment 188213: patch
https://bugs.webkit.org/attachment.cgi?id=188213&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188213&action=review


Hilarious! r+ from me since this looks like correct use of the API to me,
though you might wanna double-check with someone with more CF knowledge.

> Source/WebCore/platform/mac/SharedTimerMac.mm:154
> +    static CFRunLoopTimerRef timer;
> +    if (!timer) {

You could use dispatch_once() for this block.