[webkit-reviews] review granted: [Bug 109754] Factor HTMLTokenScanner out of HTMLPreloadScanner : [Attachment 188193] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 109754: Factor HTMLTokenScanner out of HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109754

Attachment 188193: Patch
https://bugs.webkit.org/attachment.cgi?id=188193&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188193&action=review


I think HTMLTokenScanner is decepitvely unrelated to preloading, but this is a
good factoring. :)  the preload scanner clearly needed a bath.

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:350
> +    // Note: m_token is only used from this function and for the main
thread.
> +    // All other functions are passed a token.

This is unrelated now?

> Source/WebCore/html/parser/HTMLPreloadScanner.h:44
> +    explicit HTMLTokenScanner(const KURL& documentURL);

It feels like a TokenPreloadScanner, since it still has something to do with
preloading.