[webkit-reviews] review granted: [Bug 37565] new-run-webkit-tests needs a shared TestExpectations between all WebKit ports : [Attachment 188151] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted	review:
Bug 37565: new-run-webkit-tests needs a shared TestExpectations between all
WebKit ports
https://bugs.webkit.org/show_bug.cgi?id=37565

Attachment 188151: Patch
https://bugs.webkit.org/attachment.cgi?id=188151&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188151&action=review


> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:155
> +	       expectations = TestExpectations(port, include_generic=False,
include_overrides=False)

interesting. I missed that this was doing include_overrides=False before. I
don't like having to add include_generic, but it is consistent and does make
some things easier. I think this is fine for now until I can clean up how
rebaselining handles the cascade as a whole.