[webkit-reviews] review granted: [Bug 109573] [Text Autosizing] Process narrow descendants with the same multiplier for the font size. : [Attachment 188074] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Anton Vayvod
<avayvod at chromium.org>'s request for review:
Bug 109573: [Text Autosizing] Process narrow descendants with the same
multiplier for the font size.
https://bugs.webkit.org/show_bug.cgi?id=109573

Attachment 188074: Patch
https://bugs.webkit.org/attachment.cgi?id=188074&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188074&action=review


r=me

> Source/WebCore/rendering/TextAutosizer.cpp:160
> +    // text), and use its width instead.

As you are touching this comment, why? (explaining the why here would be a nice
addition to the previous comment)

> Source/WebCore/rendering/TextAutosizer.h:64
> +    void processClusterInternal(TextAutosizingClusterInfo&, RenderBlock*
container, RenderObject* subtreeRoot, const TextAutosizingWindowInfo&, float
textWidth, bool shouldBeAutosized);

Usually boolean arguments should be avoided as they make the code less
readable. Here you never really use them directly so it's kinda OK.