[webkit-reviews] review granted: [Bug 108794] [EFL][WK2] Stop using WebString in ewk_cookie_manager, ewk_form_submission_request and ewk_text_checker : [Attachment 186391] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 108794: [EFL][WK2] Stop using WebString in ewk_cookie_manager,
ewk_form_submission_request and ewk_text_checker
https://bugs.webkit.org/show_bug.cgi?id=108794

Attachment 186391: Patch
https://bugs.webkit.org/attachment.cgi?id=186391&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186391&action=review


This is EFL code, so mostly carrying over others' reviews.

> Source/WebKit2/UIProcess/API/cpp/efl/WKEinaSharedString.cpp:119
> +    m_string = 0;

I don't know if I would expect a method named leakString() to do this.

> Source/WebKit2/UIProcess/API/efl/ewk_form_submission_request.cpp:53
> -    WKRetainPtr<WKStringRef> wkFieldName = adoptWK(toCopiedAPI(fieldName));
> +    WKRetainPtr<WKStringRef> wkFieldName(AdoptWK,
WKStringCreateWithUTF8CString(fieldName));

I think that the adoptWK() form is preferred these days, although I'm not sure
why.