[webkit-reviews] review granted: [Bug 109550] DeleteButtonController::enable and disable should be called via a RAII object : [Attachment 188113] Fixed build

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 109550: DeleteButtonController::enable and disable should be called via a
RAII object
https://bugs.webkit.org/show_bug.cgi?id=109550

Attachment 188113: Fixed build
https://bugs.webkit.org/attachment.cgi?id=188113&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188113&action=review


Nicely done. Please address my comment before landing.

> Source/WebCore/editing/markup.cpp:650
> +    RefPtr<Range> updatedRangeRef =
frame->editor()->avoidIntersectionWithDeleteButtonController(range);

There is now nothing that checks here if the frame is not NULL. If the check
was needed before I think you should add it.