[webkit-reviews] review canceled: [Bug 98935] [GTK] Add support for color input : [Attachment 182856] try to add an empty implementation of WebColorChooserProxyGtk::setSelectedColor

[bugzilla-daemon at webkit.org]

arno. <arno at renevier.net> has canceled arno. <arno at renevier.net>'s request for
review:
Bug 98935: [GTK] Add support for color input
https://bugs.webkit.org/show_bug.cgi?id=98935

Attachment 182856: try to add an empty implementation of
WebColorChooserProxyGtk::setSelectedColor
https://bugs.webkit.org/attachment.cgi?id=182856&action=review

------- Additional Comments from arno. <arno at renevier.net>
> 
> The problem of doing this here is that you can't assume the view widget is a
WebKitWebView, in case of C API users it will be a WebKitWebViewBase. Also,
WebKitColorChooserRequest is part of the GTK+ API not the C API.

This new patch fixes this issue: color chooser proxy calls
webkitWebViewBaseShowColorChooser and webkitWebViewBase has a client from
webkitWebView which it uses to notify that a color picker must be shown. I
wonder if it would be better to display the gtk default color picker from
webkitWebViewBase, and	webkitWebViewShowColorChooser to just emit a signal and
return a boolean to tell webkitWebViewBase wether or not it should display the
gtk default picker.