[webkit-reviews] review granted: [Bug 109584] [Chromium] Add support for emulating legacy Android WebView 'LoadWithOverviewMode' setting : [Attachment 188046] Alexandre's comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 11:20:40 PST 2013


Adam Barth <abarth at webkit.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 109584: [Chromium] Add support for emulating legacy Android WebView
'LoadWithOverviewMode' setting
https://bugs.webkit.org/show_bug.cgi?id=109584

Attachment 188046: Alexandre's comments addressed
https://bugs.webkit.org/attachment.cgi?id=188046&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188046&action=review


> Source/WebKit/chromium/public/WebSettings.h:57
> +    virtual bool initializeAtMinimumPageScale() const = 0;

Why do you need a getter in the public API?  Most settings don't need one.


More information about the webkit-reviews mailing list