[webkit-reviews] review granted: [Bug 107705] [Qt] window.open passes height and width parameters even if not defined in a page : [Attachment 186857] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 08:16:49 PST 2013


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Allan Sandfeld
Jensen <allan.jensen at digia.com>'s request for review:
Bug 107705: [Qt] window.open passes height and width parameters even if not
defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705

Attachment 186857: Patch
https://bugs.webkit.org/attachment.cgi?id=186857&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186857&action=review


r=me with comments

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:131
> -    if (!ewk_view_setting_enable_auto_resize_window_get(m_view))
> +    if (!ewk_view_setting_enable_auto_resize_window_get(m_view) ||
rect.isEmpty())

You should add a FIXME: An empty rect means that default size should be used.
Handle this case.

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:146
> -	   gtk_window_resize(GTK_WINDOW(window), intrect.width(),
intrect.height());
> +	   if (!intrect.isEmpty())
> +	       gtk_window_resize(GTK_WINDOW(window), intrect.width(),
intrect.height());

Same here


More information about the webkit-reviews mailing list