[webkit-reviews] review granted: [Bug 107682] [WK2][EFL] Unified text checker implementation : [Attachment 187061] comments improvements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 07:53:10 PST 2013


Anders Carlsson <andersca at apple.com> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 107682: [WK2][EFL] Unified text checker implementation
https://bugs.webkit.org/show_bug.cgi?id=107682

Attachment 187061: comments improvements
https://bugs.webkit.org/attachment.cgi?id=187061&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187061&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:68
> +#if USE(UNIFIED_TEXT_CHECKING)
> +void WebEditorClient::checkTextOfParagraph(const UChar* text, int length,
WebCore::TextCheckingTypeMask checkingTypes, Vector<TextCheckingResult>&
results)
> +{
> +   
m_page->sendSync(Messages::WebPageProxy::CheckTextOfParagraph(String(text,
length), checkingTypes),
Messages::WebPageProxy::CheckTextOfParagraph::Reply(results));
> +}
> +#endif

If USE(UNIFIED_TEXT_CHECKING) is always 1 when building on EFL, I don't think
this #if is needed.


More information about the webkit-reviews mailing list