[webkit-reviews] review granted: [Bug 109687] Web Inspector: add experimental native heap graph to Timeline panel : [Attachment 188077] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 109687: Web Inspector: add experimental native heap graph to Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=109687

Attachment 188077: Patch
https://bugs.webkit.org/attachment.cgi?id=188077&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188077&action=review


> Source/WebCore/inspector/Inspector.json:2634
> +		       { "name": "enabled", "type": "boolean", "description":
"True to start collecting statisics on native memory usage." }

Please rephrase to include the disablement (false) case

> Source/WebCore/inspector/Inspector.json:2626
> +		       { "name": "enabled", "type": "boolean", "description":
"True to start reporting DOM counters." }

Please rephrase to include the stop (false) case

> Source/WebCore/inspector/Inspector.json:2634
> +		       { "name": "enabled", "type": "boolean", "description":
"True to start collecting statisics on native memory usage." }

Please rephrase to include the stop (false) case

> Source/WebCore/inspector/Inspector.json:2637
> +		   "description": "Starts sending statistics on native memory
usage along with timeline events."

"Starts sending" -> "Whether to send"?