[webkit-reviews] review denied: [Bug 109675] Web Inspector: [DTE] use DOM event propogation instead of manual one. : [Attachment 188039] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 109675: Web Inspector: [DTE] use DOM event propogation instead of manual
one.
https://bugs.webkit.org/show_bug.cgi?id=109675

Attachment 188039: Patch
https://bugs.webkit.org/attachment.cgi?id=188039&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188039&action=review


Looks like you could remove one of this handlers all together and use only one
of them.

> Source/WebCore/ChangeLog:3
> +	   Web Inspector: [DTE] use DOM event propogation instead of manual
one.

propagation

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:-442
> -	   this._mainPanel.handleKeyDown(shortcutKey, e);

You are going to regress the bug mentioned in the beginning of this method.