[webkit-reviews] review canceled: [Bug 109434] Web Inspector: Colorpicker not saving values : [Attachment 188050] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Vladislav
Kaznacheev <kaznacheev at chromium.org>'s request for review:
Bug 109434: Web Inspector: Colorpicker not saving values
https://bugs.webkit.org/show_bug.cgi?id=109434

Attachment 188050: Patch
https://bugs.webkit.org/attachment.cgi?id=188050&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188050&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1786
> +		       var scrollerElement =
self._parentPane.container().scrollTarget();

Can the scrollerElement change while the color picker is active? (E.g. if the
user resizes the web inspector window, which can alter the sidebar pane
representation)

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1788
> +		       console.log("detached scroll listener from ",
scrollerElement);

Please remove debug logging

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1822
> +			       console.log("attached scroll listener to ",
scrollerElement);

Ditto