[webkit-reviews] review canceled: [Bug 109585] Web Inspector: highlight undefined word in JavaScript : [Attachment 187867] Patch

[bugzilla-daemon at webkit.org]

Andrey Lushnikov <lushnikov at chromium.org> has canceled Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 109585: Web Inspector: highlight undefined word in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=109585

Attachment 187867: Patch
https://bugs.webkit.org/attachment.cgi?id=187867&action=review

------- Additional Comments from Andrey Lushnikov <lushnikov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187867&action=review


>> Source/WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js:176
>> +			if (token === "undefined")
> 
> I would rather add something like
WebInspector.SourceJavaScriptTokenizer.GlobalObjectProperties and put NaN,
Object, String, Number there as well as undefined.

Sounds reasonable