[webkit-reviews] review granted: [Bug 109345] Create the SharedGraphicsContext3D through its own method. : [Attachment 188017] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 12 23:17:55 PST 2013
James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 109345: Create the SharedGraphicsContext3D through its own method.
https://bugs.webkit.org/show_bug.cgi?id=109345
Attachment 188017: Patch
https://bugs.webkit.org/attachment.cgi?id=188017&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188017&action=review
> Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:75
> + GrContext* grContext =
WebKit::Platform::current()->sharedOffscreenGrContext();
to stage this, perhaps this should fall back on the current path if the
embedder fails to provide a context? or will you just make sure to land an
implementation of this function in chromium before landing this?
More information about the webkit-reviews
mailing list