[webkit-reviews] review granted: [Bug 109642] [Internals] setShadowDOMEnabled() shouldn't be used except a few tests : [Attachment 187991] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 23:06:50 PST 2013


Kent Tamura <tkent at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 109642: [Internals] setShadowDOMEnabled() shouldn't be used except a few
tests
https://bugs.webkit.org/show_bug.cgi?id=109642

Attachment 187991: Patch
https://bugs.webkit.org/attachment.cgi?id=187991&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187991&action=review


Looks ugly hack. But I also have no other ideas.

> Source/WebCore/ChangeLog:8
> +	   InternalSettings.setShadowDOMEnabled() shouldn't be alled after

alled -> called?

> Source/WebCore/testing/InternalSettings.cpp:198
> +static bool urlIsWhitelisted(const String& url)

The function name is too generic.  urlIsInWhitelistForSetShadowDOMEnabled?


More information about the webkit-reviews mailing list