[webkit-reviews] review granted: [Bug 109623] Fix signedness in WebTestProxy : [Attachment 187949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 15:31:42 PST 2013


Adam Barth <abarth at webkit.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 109623: Fix signedness in WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=109623

Attachment 187949: Patch
https://bugs.webkit.org/attachment.cgi?id=187949&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187949&action=review


> Tools/ChangeLog:19
> +2013-02-12  Alec Flett  <alecflett at chromium.org>
> +
> +	   Fix signedness in WebTestProxy
> +	   https://bugs.webkit.org/show_bug.cgi?id=109623
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fix signedness problem, using size_t instead of int.
> +
> +	   * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
> +
> +2013-02-12  Alec Flett  <alecflett at chromium.org>
> +
> +	   Fix signedness in WebTestProxy
> +	   https://bugs.webkit.org/show_bug.cgi?id=109623
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

You have a goofy looking changelog


More information about the webkit-reviews mailing list