[webkit-reviews] review granted: [Bug 109619] Use fancy new Vector-based String constructors in the WebVTT parser : [Attachment 187945] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 109619: Use fancy new Vector-based String constructors in the WebVTT parser
https://bugs.webkit.org/show_bug.cgi?id=109619

Attachment 187945: Patch
https://bugs.webkit.org/attachment.cgi?id=187945&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187945&action=review


Looks great.

> Source/WebCore/html/track/WebVTTParser.cpp:382
> +	   String content(m_token.characters()); // FIXME: Can this be 8bit?

I would not put this Fixme. Without context of your current work, it will be
impossible to know what you meant.

> Source/WebCore/html/track/WebVTTParser.cpp:422
> +	   // FIXME: m_token.characters should normally be 8-bit!

Maybe?

// FIXME: m_token.characters should normally be 8-bit! Should we convert the
input string to 8bits if possible.