[webkit-reviews] review granted: [Bug 109617] Teach more WTF string classes about vectors with inline capacity : [Attachment 187940] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 109617: Teach more WTF string classes about vectors with inline capacity
https://bugs.webkit.org/show_bug.cgi?id=109617

Attachment 187940: Patch
https://bugs.webkit.org/attachment.cgi?id=187940&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187940&action=review


> Source/WTF/ChangeLog:9
> +	   I'm about to deploy these all over the HTML/WebVTT parser code
> +	   to make our string creation much less verbose.

Let's explain the changes here instead!

> Source/WTF/wtf/text/AtomicString.h:67
> +
> +    template<size_t inlineCapacity>
> +    explicit AtomicString(Vector<UChar, inlineCapacity> characters)
> +	   : m_string(add(characters.data(), characters.size()))
> +    {
> +    }
> +

This is in the middle of the two constructor from literal.
I would instead put this close to the constructors taking a UChar*