[webkit-reviews] review granted: [Bug 108451] [EFL][WK2] Reenable ewk_auth_request API tests : [Attachment 185733] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 13:46:27 PST 2013

Benjamin Poulain <benjamin at webkit.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 108451: [EFL][WK2] Reenable ewk_auth_request API tests

Attachment 185733: Patch

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185733&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:40
>  static const char TEST_USERNAME[] = "username";
>  static const char TEST_PASSWORD[] = "password";
> +static const char EXPECTED_SUCCESS_TITLE[] = "EFLWebKit2 Authentication
>  static const char EXPECTED_AUTHORIZATION[] = "Basic
dXNlcm5hbWU6cGFzc3dvcmQ="; // Base64 encoding of "username:password".
>  static const char INDEX_HTML_STRING[] =

This style is a bit far from WebKit style.

More information about the webkit-reviews mailing list