[webkit-reviews] review requested: [Bug 108598] [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API : [Attachment 187919] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 13:22:31 PST 2013


Christophe Dumez <dchris at gmail.com> has asked  for review:
Bug 108598: [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal
C++ API
https://bugs.webkit.org/show_bug.cgi?id=108598

Attachment 187919: Patch
https://bugs.webkit.org/attachment.cgi?id=187919&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
Take Mikhail's feedback into consideration. Note that I renamed
ewk_view_favicon_new() to ewk_view_favicon_get() since it seems to be according
to EFL style and it is documented that the returned value needs to be freed.
Also, it is consistent with ewk_favicon_database_icon_get().


More information about the webkit-reviews mailing list