[webkit-reviews] review denied: [Bug 107351] WebSpeech: plumb through a method to generate fake speech jobs for testing : [Attachment 187881] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 107351: WebSpeech: plumb through a method to generate fake speech jobs for
testing
https://bugs.webkit.org/show_bug.cgi?id=107351

Attachment 187881: patch
https://bugs.webkit.org/attachment.cgi?id=187881&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This isn't a very appealing approach to mocking out speak synthesis.  It's
generally better to cleanly separate mock code from production code.  Ideally
the mock code isn't linked into the production binary at all.  In other places,
we've mocked out subsystems at the Platform API boundary, but I understand that
might not work well for ports like apple-mac that interact directly with the
underlying operating system.