[webkit-reviews] review granted: [Bug 109329] Add WKContext API to retrieve basic network process statistics : [Attachment 187909] Patch v3 - Based on Sam's feedback

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 109329: Add WKContext API to retrieve basic network process statistics
https://bugs.webkit.org/show_bug.cgi?id=109329

Attachment 187909: Patch v3 - Based on Sam's feedback
https://bugs.webkit.org/attachment.cgi?id=187909&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187909&action=review


> Source/WebKit2/UIProcess/API/C/WKContext.h:150
> +enum {
> +    kWKStatisticsTypeWebContent = 0x00000001,
> +    kWKStatisticsTypeNetworking = 0x00000002
> +};
> +typedef uint32_t WKStatisticsType;

Please use 0 << 1 and such.

> Source/WebKit2/UIProcess/API/C/WKContext.h:197
> +WK_EXPORT void WKContextGetStatisticsWithOptions(WKContextRef context,
WKStatisticsType statisticsMask, void* functionContext,
WKContextGetStatisticsFunction function);

This doesn't take options.  Please rename.