[webkit-reviews] review granted: [Bug 107714] [Windows] Update WebKitDirs.pm for new Windows paths : [Attachment 187647] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 107714: [Windows] Update WebKitDirs.pm for new Windows paths
https://bugs.webkit.org/show_bug.cgi?id=107714

Attachment 187647: Patch
https://bugs.webkit.org/attachment.cgi?id=187647&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187647&action=review


> Tools/Scripts/webkitdirs.pm:1702
>	       print "Warning: You must set the 'WebKitLibrariesDir'
environment variable\n";
>	       print "	       to be able build WebKit from within Visual
Studio.\n";
>	       print "	       Make sure that 'WebKitLibrariesDir' points to
the\n";
>	       print "	       'WebKitLibraries/win' directory, not the
'WebKitLibraries/' directory.\n\n";

For your consideration I suggest we make it clear that this warning is
applicable when building with Visual Studio 2005 by explicitly mentioning
"Visual Studio 2005" similar to what you did in the Visual Studio 2010 warning
messages (below).

> Tools/Scripts/webkitdirs.pm:1715
> +	       # VS2005 version.  This will be removed as part of
https://bugs.webkit.org/show_bug.cgi?id=109472.
>	       print "Warning: You must set the 'WebKitOutputDir' environment
variable\n";
>	       print "	       to be able build WebKit from within Visual
Studio.\n\n";

Ditto.