[webkit-reviews] review granted: [Bug 109549] Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller : [Attachment 187798] Fixed build

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 109549: Turn avoidIntersectionWithNode into Editor member functions to
encapsulate delete button controller
https://bugs.webkit.org/show_bug.cgi?id=109549

Attachment 187798: Fixed build
https://bugs.webkit.org/attachment.cgi?id=187798&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187798&action=review


> Source/WebCore/editing/Editor.h:105
> +    PassRefPtr<Range> avoidIntersectionWithDeleteButtonController(const
Range* range) const { return range ? range->cloneRange(ASSERT_NO_EXCEPTION) :
0; }

Maybe mention why we need to clone the range in the ChangeLog?

> Source/WebCore/editing/markup.cpp:642
> +    // Disable the delete button so it's elements are not serialized into
the markup,

Nit: it's -> its