[webkit-reviews] review denied: [Bug 108357] REGRESSION(r140907): Incorrect baseline for cells with media content during load : [Attachment 187423] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has denied Robert Hogan
<robert at webkit.org>'s request for review:
Bug 108357: REGRESSION(r140907): Incorrect baseline for cells with media
content during load
https://bugs.webkit.org/show_bug.cgi?id=108357

Attachment 187423: Patch
https://bugs.webkit.org/attachment.cgi?id=187423&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187423&action=review


> Source/WebCore/rendering/RenderTableCell.cpp:258
> +	   layoutBlock(cellWidthChanged());

I don't think this is the right way. 

First if you don't call setNeedsLayout, this will ASSERT in debug.
Second, baseline computation are done by RenderTableSection (layoutRows) so
this should be handled there.
By lastly, I don't think I understand the issue. The image loading should
trigger a relayout (including the row / section so that we recompute the
baseline appropriately) and if that's not the case, then we should fix that,
not force 2 layout phases every time this function is called.

>
LayoutTests/http/tests/css/vertical-align-baseline-after-image-load-expected.ht
ml:12
> +	   return "http://127.0.0.1:8000/resources/load-and-stall.php";

Tests using the http server should be inside the http/tests/ directory or else
the server may not be started.