[webkit-reviews] review granted: [Bug 109330] [CSS Filters] Refactor filter outsets into a class : [Attachment 187618] Patch for Review

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Max Vujovic <mvujovic at adobe.com>'s
request for review:
Bug 109330: [CSS Filters] Refactor filter outsets into a class
https://bugs.webkit.org/show_bug.cgi?id=109330

Attachment 187618: Patch for Review
https://bugs.webkit.org/attachment.cgi?id=187618&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187618&action=review


> Source/WebCore/platform/graphics/IntRectOutsets.h:16
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER “AS IS” AND ANY

Not sure if this is a error in the review tool or the patch (the cruft around
AS IS)

> Source/WebCore/platform/graphics/IntRectOutsets.h:39
> +class IntRectOutsets {

I wonder if this should be called OutsetsIntRect? Our other rect classes are of
the form <Type>Rect (e.g. IntRect) and <Usecase>Rect (e.g. LayoutRect). So it
makes sense to be called <Usecase><Type>Rect.