[webkit-reviews] review granted: [Bug 109578] Web Inspector: add initial implementation of native memory graph to Timeline : [Attachment 187862] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 109578: Web Inspector: add initial implementation of native memory graph to
Timeline
https://bugs.webkit.org/show_bug.cgi?id=109578

Attachment 187862: Patch
https://bugs.webkit.org/attachment.cgi?id=187862&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187862&action=review


> Source/WebCore/WebCore.vcproj/WebCore.vcproj:77345
> +				       
RelativePath="..\inspector\front-end\NativeMemoryGraph.js"

Move down below

> Source/WebCore/inspector/front-end/NativeMemoryGraph.js:53
> +    var borderLightnessDifference = 3;

const

> Source/WebCore/inspector/front-end/NativeMemoryGraph.js:103
> +	   function getCounterValue(name, entry)

jsdoc?

> Source/WebCore/inspector/front-end/NativeMemoryGraph.js:115
> +		   var counterUI = new WebInspector.NativeMemoryCounterUI(this,
name, [i*20, 65, 63], getCounterValue.bind(this, name))

i * 20

> Source/WebCore/inspector/front-end/NativeMemoryGraph.js:127
> +    _onRecordAdded: function(event)

jsdoc here and below

> Source/WebCore/inspector/front-end/NativeMemoryGraph.js:140
> +	       for (var n in nativeCounters) {

n -> name ?

> Source/WebCore/inspector/front-end/NativeMemoryGraph.js:199
> +	       imageData: imageData };

"}" on the next line

> Source/WebCore/inspector/front-end/WebKit.qrc:116
> +    <file>NativeMemoryGraph.js</file>

Move down below