[webkit-reviews] review granted: [Bug 106159] Remove the bitmap SVG image cache : [Attachment 187765] Add tests for newly-fixed bugs

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Philip Rogers
<pdr at google.com>'s request for review:
Bug 106159: Remove the bitmap SVG image cache
https://bugs.webkit.org/show_bug.cgi?id=106159

Attachment 187765: Add tests for newly-fixed bugs
https://bugs.webkit.org/attachment.cgi?id=187765&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187765&action=review


I'm having trouble finding anything to complain about! Let's see how it goes, I
guess? I'm really excited.

> Source/WebCore/svg/graphics/SVGImage.h:67
> +    friend class SVGImageForContainer;

The "ForContainer" prefix struck me as a little odd the first time I saw it,
but I've quickly gotten used to it.

> Source/WebCore/svg/graphics/SVGImageForContainer.h:71
> +    void setPageScale(float pageScale) { m_pageScale = pageScale; }

This is the product of page scale and device scale, yes? Slightly confusing --
we already make this confusing enough :D