[webkit-reviews] review canceled: [Bug 109430] Web Inspector: separate SuggestBox from TextPrompt : [Attachment 187816] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 109430: Web Inspector: separate SuggestBox from TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=109430

Attachment 187816: Patch
https://bugs.webkit.org/attachment.cgi?id=187816&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187816&action=review


> Source/WebCore/inspector/front-end/TextPrompt.js:950
> +WebInspector.TextPrompt.SuggestBoxDelegate = function ()

extra whitespace before "()"

> Source/WebCore/inspector/front-end/TextPrompt.js:954
> +WebInspector.TextPrompt.SuggestBoxDelegate.prototype = {

This should rather be WebInspector.SuggestBoxDelegate, next to
WebInspector.SuggestBox

> Source/WebCore/inspector/front-end/TextPrompt.js:975
> +WebInspector.TextPrompt.SuggestBox = function(suggestBoxDelegate,
inputElement, className)

This should become WebInspector.SuggestBox, preferably in its own file