[webkit-reviews] review granted: [Bug 109308] Web Inspector: Add command for selecting files for file input element : [Attachment 187711] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 01:55:46 PST 2013


Yury Semikhatsky <yurys at chromium.org> has granted Ken Kania
<kkania at chromium.org>'s request for review:
Bug 109308: Web Inspector: Add command for selecting files for file input
element
https://bugs.webkit.org/show_bug.cgi?id=109308

Attachment 187711: Patch
https://bugs.webkit.org/attachment.cgi?id=187711&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187711&action=review


> LayoutTests/inspector-protocol/dom/setFileInputFiles.html:6
> +window.addEventListener("load", onLoad);

To make it clear that onLoad is executed before runtTest I'd put runtTest()
call at the end of onLoad and set onLoad as onload handler for <body>

> LayoutTests/inspector-protocol/dom/setFileInputFiles.html:24
> +    function abortOnError(msg)

WebKit style guide discourages using abbreviations.


More information about the webkit-reviews mailing list